Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(zt): add metadrive-simulator env and related onppo config #574

Merged
merged 10 commits into from
Feb 15, 2023

Conversation

timothijoe
Copy link
Contributor

Description

add metadrive simulator into DI-engine.

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #574 (bca738e) into main (e30bcc0) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   83.67%   83.59%   -0.08%     
==========================================
  Files         564      564              
  Lines       46110    46196      +86     
==========================================
+ Hits        38582    38618      +36     
- Misses       7528     7578      +50     
Flag Coverage Δ
unittests 83.59% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/framework/message_queue/tests/test_nng.py 73.07% <0.00%> (-26.93%) ⬇️
ding/framework/event_loop.py 90.16% <0.00%> (-3.28%) ⬇️
ding/utils/compression_helper.py 71.92% <0.00%> (-1.99%) ⬇️
ding/model/common/head.py 96.86% <0.00%> (-1.71%) ⬇️
ding/envs/env/ding_env_wrapper.py 85.52% <0.00%> (-1.70%) ⬇️
ding/model/common/encoder.py 94.28% <0.00%> (-1.37%) ⬇️
ding/interaction/slave/slave.py 85.58% <0.00%> (-0.44%) ⬇️
ding/interaction/master/master.py 90.61% <0.00%> (-0.41%) ⬇️
ding/policy/ppof.py 16.47% <0.00%> (-0.39%) ⬇️
ding/envs/env_manager/subprocess_env_manager.py 75.21% <0.00%> (-0.21%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 added the env Questions about RL environment label Feb 7, 2023
dizoo/metadrive/env/drive_wrapper.py Outdated Show resolved Hide resolved
dizoo/metadrive/env/drive_wrapper.py Outdated Show resolved Hide resolved
dizoo/metadrive/env/drive_utils.py Outdated Show resolved Hide resolved
dizoo/metadrive/env/drive_env.py Show resolved Hide resolved
dizoo/metadrive/env/drive_env.py Show resolved Hide resolved
dizoo/metadrive/config/test_ppo.py Outdated Show resolved Hide resolved
dizoo/metadrive/config/test_ppo.py Outdated Show resolved Hide resolved
dizoo/metadrive/config/test_ppo.py Outdated Show resolved Hide resolved
dizoo/metadrive/config/test_ppo.py Outdated Show resolved Hide resolved
dizoo/metadrive/config/test_ppo.py Outdated Show resolved Hide resolved
dizoo/metadrive/env/drive_env.py Outdated Show resolved Hide resolved
dizoo/metadrive/env/drive_env.py Show resolved Hide resolved
dizoo/metadrive/env/drive_env.py Show resolved Hide resolved
dizoo/metadrive/env/drive_env.py Show resolved Hide resolved
dizoo/metadrive/env/drive_env.py Outdated Show resolved Hide resolved
dizoo/metadrive/config/test_ppo.py Outdated Show resolved Hide resolved
dizoo/metadrive/config/test_ppo.py Outdated Show resolved Hide resolved
dizoo/metadrive/config/train_ppo.py Outdated Show resolved Hide resolved
dizoo/metadrive/config/train_ppo.py Outdated Show resolved Hide resolved
exp_name='train_ppo_metadrive',
env=dict(
metadrive=dict(
use_render = False,
Copy link
Collaborator

@puyuan1996 puyuan1996 Feb 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no space near =, execute bash format.sh diizoo/metadrive to reformat the files

env=dict(
metadrive=dict(
use_render = False,
traffic_density=0.10,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some anatations about the key parameters in metadrive env?

dizoo/metadrive/config/test_ppo.py Outdated Show resolved Hide resolved
dizoo/metadrive/config/test_ppo.py Outdated Show resolved Hide resolved
dizoo/metadrive/env/drive_env.py Show resolved Hide resolved
dizoo/metadrive/env/drive_wrapper.py Outdated Show resolved Hide resolved
dizoo/metadrive/env/drive_utils.py Outdated Show resolved Hide resolved
dizoo/metadrive/env/drive_wrapper.py Outdated Show resolved Hide resolved
@puyuan1996 puyuan1996 changed the title feature(zt): add metadrive-simulator env feature(zt): add metadrive-simulator env and related onppo config Feb 12, 2023
@PaParaZz1 PaParaZz1 merged commit 0472a3a into opendilab:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env Questions about RL environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants